Return-Path: 
 <issues-return-78632-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B21A0E516
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon, 28 Jan 2013 02:19:13 +0000 (UTC)
Received: (qmail 26450 invoked by uid 500); 28 Jan 2013 02:19:13 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 26359 invoked by uid 500); 28 Jan 2013 02:19:13 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 26131 invoked by uid 99); 28 Jan 2013 02:19:13 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2013 02:19:13 +0000
Date: Mon, 28 Jan 2013 02:19:13 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12629467.1359337792053.199104.1359339553207@arcas>
In-Reply-To: <JIRA.12629467.1359337792053@arcas>
References: <JIRA.12629467.1359337792053@arcas>
Subject: [jira] [Commented] (HBASE-7689) CloneTableHandler notify completion
 too early
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563989#comment-13563989 ] 

Ted Yu commented on HBASE-7689:
-------------------------------

{code}
+      completed();
       if (cpHost != null) {
         cpHost.postCreateTableHandler(this.hTableDescriptor, this.newRegions);
       }
{code}
What if call of postCreateTableHandler() results in exception ?
I think call to completed() should be moved after call to postCreateTableHandler()

Otherwise patch looks good.
                
> CloneTableHandler notify completion too early
> ---------------------------------------------
>
>                 Key: HBASE-7689
>                 URL: https://issues.apache.org/jira/browse/HBASE-7689
>             Project: HBase
>          Issue Type: Sub-task
>          Components: snapshots
>    Affects Versions: hbase-6055
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>             Fix For: hbase-6055, 0.96.0
>
>         Attachments: HBASE-7689-v0.patch
>
>
> With HBASE-7365 the clone table handler notify that the clone is finished before the base create table handler has moved the table folder in place and added regions to .META.
> If the client call isRestoreDone() before the META+disk update gets an exception like this:
> {code}
> org.apache.hadoop.hbase.TableNotFoundException: clonedtb-1359268409309
> 	at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegionInMeta(HConnectionManager.java:991)
> 	at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:856)
> 	at org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.locateRegion(HConnectionManager.java:813)
> 	at org.apache.hadoop.hbase.client.HTable.finishSetup(HTable.java:234)
> 	at org.apache.hadoop.hbase.client.HTable.<init>(HTable.java:174)
> 	at org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.verifyRowCount(TestRestoreSnapshotFromClient.java:387)
> 	at org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testCloneSnapshot(TestRestoreSnapshotFromClient.java:259)
> 	at org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testCloneSnapshot(TestRestoreSnapshotFromClient.java:251)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira