Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D73B5E0CF for ; Sun, 27 Jan 2013 08:11:14 +0000 (UTC) Received: (qmail 71941 invoked by uid 500); 27 Jan 2013 08:11:14 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 71708 invoked by uid 500); 27 Jan 2013 08:11:14 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 71671 invoked by uid 99); 27 Jan 2013 08:11:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jan 2013 08:11:13 +0000 Date: Sun, 27 Jan 2013 08:11:13 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7545) [replication] Break out TestReplication into manageable classes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563764#comment-13563764 ] Lars Hofhansl commented on HBASE-7545: -------------------------------------- Still wanna make a 0.94 patch, [~jdcryans]? > [replication] Break out TestReplication into manageable classes > --------------------------------------------------------------- > > Key: HBASE-7545 > URL: https://issues.apache.org/jira/browse/HBASE-7545 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Fix For: 0.96.0 > > Attachments: HBASE-7545.patch > > > This has been discussed before but after trying to debug the last failure on Jenkins where I saw the time go back and forth (if you don't care about your own sanity do checkout https://builds.apache.org/job/HBase-TRUNK/3726/testReport/junit/org.apache.hadoop.hbase.replication/TestReplicationWithCompression/testDeleteTypes/) I think it is time to break out TestReplication. > The difficulty is that the setup for the 2 clusters is a lot of code I don't want to duplicate. I'm thinking that we can keep {{setUpBeforeClass}} there and have the other classes extend TestReplication (which should also change name). I'm thinking of the following new classes: > - TestReplicationSmallTests, contains the easy methods that don't mess around too much. > - TestReplicationQueueFailover, contains one test of the same name > - TestReplicationDisableInactivePeer, contains one test of the same name > - Rename TestReplicationWithCompression TestReplicationQueueFailoverWithCompression and make it extends TestReplicationQueueFailover. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira