Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAD37E636 for ; Fri, 11 Jan 2013 08:08:13 +0000 (UTC) Received: (qmail 26500 invoked by uid 500); 11 Jan 2013 08:08:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 26333 invoked by uid 500); 11 Jan 2013 08:08:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 26319 invoked by uid 99); 11 Jan 2013 08:08:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2013 08:08:13 +0000 Date: Fri, 11 Jan 2013 08:08:13 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7506) Judgment of carrying ROOT/META will become wrong when expiring server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550960#comment-13550960 ] Hudson commented on HBASE-7506: ------------------------------- Integrated in HBase-0.94 #723 (See [https://builds.apache.org/job/HBase-0.94/723/]) HBASE-7506 Judgment of carrying ROOT/META will become wrong when expiring server (Chunhui) (Revision 1431903) Result = SUCCESS zjushch : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java > Judgment of carrying ROOT/META will become wrong when expiring server > --------------------------------------------------------------------- > > Key: HBASE-7506 > URL: https://issues.apache.org/jira/browse/HBASE-7506 > Project: HBase > Issue Type: Bug > Affects Versions: 0.94.3 > Reporter: chunhui shen > Assignee: chunhui shen > Fix For: 0.96.0, 0.94.5 > > Attachments: 7506-94.patch, 7506-trunk v1.patch, 7506-trunkv1.patch, 7506-trunkv2.patch > > > We will check whether server carrying ROOT/META when expiring the server. > See ServerManager#expireServer. > If the dead server carrying META, we assign meta directly in the process of ServerShutdownHandler. > If the dead server carrying ROOT, we will offline ROOT and then verifyAndAssignRootWithRetries() > How judgement of carrtying ROOT/META become wrong? > If region is in RIT, and isCarryingRegion() return true after addressing from zk. > However, once RIT time out(could be caused by this.allRegionServersOffline && !noRSAvailable, see AssignmentManager#TimeoutMonitor) and we assign it to otherwhere, this judgement become wrong. > See AssignmentManager#isCarryingRegion for details > With the wrong judgement of carrtying ROOT/META, we would assign ROOT/META twice. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira