Return-Path: 
 <issues-return-74504-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6D99DE79B
	for <apmail-hbase-issues-archive@www.apache.org>;
 Fri,  4 Jan 2013 01:13:25 +0000 (UTC)
Received: (qmail 1921 invoked by uid 500); 4 Jan 2013 01:13:25 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 1886 invoked by uid 500); 4 Jan 2013 01:13:25 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 1875 invoked by uid 99); 4 Jan 2013 01:13:25 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jan 2013 01:13:25 +0000
Date: Fri, 4 Jan 2013 01:13:25 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12625888.1357237603074.77784.1357262005029@arcas>
In-Reply-To: <JIRA.12625888.1357237603074@arcas>
References: <JIRA.12625888.1357237603074@arcas>
Subject: [jira] [Commented] (HBASE-7488) Implement
 HConnectionManager.locateRegions which is currently returning null.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-7488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543493#comment-13543493 ] 

Matteo Bertozzi commented on HBASE-7488:
----------------------------------------

{code}
    public List<HRegionLocation> locateRegions(final byte [] tableName)
    public List<HRegionLocation> locateRegions(byte[] tableName)
{code}
tableName has lost a final, but doesn't changed in the method, and is just passed to another locateRegions() with the tableName as final. (just add it back)

{code}
      return parseRegionName(regionName)[1];
    } catch (IOException e) {
      LOG.error(
        "Error while retrieving the start key from region " + ytes.toStringBinary(regionName), e);
    }
{code}
Not sure if we should be silent about that... the regioName is malformed and the request goes on with a null key, and the result probably is not the one expected.
                
> Implement HConnectionManager.locateRegions which is currently returning null.
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-7488
>                 URL: https://issues.apache.org/jira/browse/HBASE-7488
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Critical
>              Labels: HConnectionManager
>         Attachments: HBASE-7488-v0-0.94.patch, HBASE-7488-v0-trunk.patch, HBASE-7488-v1-trunk.patch, HBASE-7488-v2-trunk.patch, HBASE-7488-v3-trunk.patch, HBASE-7488-v4-trunk.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira