Return-Path: 
 <issues-return-74550-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id F3C05EFD2
	for <apmail-hbase-issues-archive@www.apache.org>;
 Fri,  4 Jan 2013 06:32:22 +0000 (UTC)
Received: (qmail 96563 invoked by uid 500); 4 Jan 2013 06:32:22 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 96364 invoked by uid 500); 4 Jan 2013 06:32:22 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 96075 invoked by uid 99); 4 Jan 2013 06:32:20 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jan 2013 06:32:20 +0000
Date: Fri, 4 Jan 2013 06:32:20 +0000 (UTC)
From: "Hiroshi Ikeda (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12625205.1356414494472.78882.1357281140479@arcas>
In-Reply-To: <JIRA.12625205.1356414494472@arcas>
References: <JIRA.12625205.1356414494472@arcas>
Subject: [jira] [Updated] (HBASE-7434) Use generics appropriately in
 RPCEngine and reduce casts, with fixing a related bug of breaking
 thread-safety in HConnectionManager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HBASE-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hiroshi Ikeda updated HBASE-7434:
---------------------------------

    Attachment: HBASE-7434-V2.patch

Patch v2 from review board.

By the way I just changed the title at the previous update in the review board.
                
> Use generics appropriately in RPCEngine and reduce casts, with fixing a related bug of breaking thread-safety in HConnectionManager
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7434
>                 URL: https://issues.apache.org/jira/browse/HBASE-7434
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Hiroshi Ikeda
>            Assignee: Hiroshi Ikeda
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7434.patch, HBASE-7434-V2.patch
>
>
> In RpcEngine,
> {code}
>   VersionedProtocol getProxy(Class<? extends VersionedProtocol> protocol, ...)
> {code}
> should be
> {code}
>   <T extends VersionedProtocol> T getProxy(Class<T> protocol, ...)
> {code}
> Also, while removing casts I encountered a bug of the method HConnectionManager.HConnectionImplementation.getProtocol() using broken logic just like double-checked locking for HashMap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira