Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 5 Jan 2013 03:12:13 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12624917.1356045636990.84714.1357355533443@arcas>
In-Reply-To: <JIRA.12624917.1356045636990@arcas>
References: <JIRA.12624917.1356045636990@arcas>
Subject: [jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544547#comment-13544547 ] 

Ted Yu commented on HBASE-7414:
-------------------------------

{code}
+    if (majorVersion > 2 || (majorVersion == 2 && minorVersion >= PBUF_TRAILER_MINOR_VERSION)) {
...
+  void deserializeFromPB(DataInputStream inputStream) throws IOException {
+    expectMinorVersion(PBUF_TRAILER_MINOR_VERSION);
{code}
expectMinorVersion() only checks minorVersion for equality. So when majorVersion goes to 3, we shouldn't be checking minorVersion, right ?
                
> Convert some HFile metadata to PB
> ---------------------------------
>
>                 Key: HBASE-7414
>                 URL: https://issues.apache.org/jira/browse/HBASE-7414
>             Project: HBase
>          Issue Type: Task
>          Components: HFile
>            Reporter: stack
>            Assignee: Andrew Purtell
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 7414.patch
>
>
> See HBASE-7201
> Convertion should be in a manner that does not prevent our being able to read old style hfiles with Writable metadata.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira