Return-Path: 
 <issues-return-74655-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 438F6E6D1
	for <apmail-hbase-issues-archive@www.apache.org>;
 Fri,  4 Jan 2013 22:14:15 +0000 (UTC)
Received: (qmail 17900 invoked by uid 500); 4 Jan 2013 22:14:14 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 17858 invoked by uid 500); 4 Jan 2013 22:14:14 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 17812 invoked by uid 99); 4 Jan 2013 22:14:14 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Jan 2013 22:14:14 +0000
Date: Fri, 4 Jan 2013 22:14:14 +0000 (UTC)
From: "Gary Helmling (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12624860.1356025766968.83239.1357337654099@arcas>
In-Reply-To: <JIRA.12624860.1356025766968@arcas>
References: <JIRA.12624860.1356025766968@arcas>
Subject: [jira] [Commented] (HBASE-7405) Enforce PB ser/de for Aggregate
 protocol and associated ColumnInterpreter user code bits
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544295#comment-13544295 ] 

Gary Helmling commented on HBASE-7405:
--------------------------------------

Just a couple documentation nits below.  If you fix up these, I'm +1 on the v5 patch.

In ColumnInterpreter, javadoc for getRequestData() needs to be updated for change to initialize() signature.  Should be:
{noformat}
-   * will pass this to the {@link #initialize(ByteString)}
+   * will pass this to the {@link #initialize(P)}
{noformat}

In AggregateImplementation, add doc for each type parameter in class javadoc:
{noformat}

 /**
  * A concrete AggregateProtocol implementation. Its system level coprocessor
  * that computes the aggregate function at a region level.
+ * {@link ColumnInterpreter} has the explanation for the params.
  * @param <T>
  * @param <S>
+ * @param <P>
+ * @param <Q>
+ * @param <R>
  */
{noformat}
                
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter user code bits
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-7405
>                 URL: https://issues.apache.org/jira/browse/HBASE-7405
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors, Protobufs
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 7405-1.patch, 7405-2.patch, 7405-3.patch, 7405-4.patch, 7405-5.patch
>
>
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter user code bits

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira