Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D2B22EC05 for ; Sun, 13 Jan 2013 23:22:13 +0000 (UTC) Received: (qmail 35685 invoked by uid 500); 13 Jan 2013 23:22:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 35563 invoked by uid 500); 13 Jan 2013 23:22:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 35554 invoked by uid 99); 13 Jan 2013 23:22:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Jan 2013 23:22:13 +0000 Date: Sun, 13 Jan 2013 23:22:13 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-5945) Reduce buffer copies in IPC server response path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552350#comment-13552350 ] stack commented on HBASE-5945: ------------------------------ bq. ....are you saying that we preserve most of the current RPC header/body structure, and commit the patch here with a focus on removing buffer copies? No. If we do that, we have to put rpc back together twice because it will have changed radically twice. We will also reduce buffer copies that we may not be of use in the final rpc incarnation. I was thinking we do the spec first over in 7533. This issue would be about saving buffer copies after we put rpc back together after 7533. > Reduce buffer copies in IPC server response path > ------------------------------------------------ > > Key: HBASE-5945 > URL: https://issues.apache.org/jira/browse/HBASE-5945 > Project: HBase > Issue Type: Improvement > Components: IPC/RPC > Affects Versions: 0.96.0 > Reporter: Todd Lipcon > Assignee: stack > Priority: Blocker > Fix For: 0.96.0 > > Attachments: 5945-in-progress.2.1.patch, 5945-in-progress.2.patch, 5945-in-progress.patch, buffer-copies.txt, even-fewer-copies.txt, hbase-5495.txt > > > The new PB code is sloppy with buffers and makes several needless copies. This increases GC time a lot. A few simple changes can cut this back down. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira