hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7692) Add utility class to generate ordered byte[] serialization
Date Thu, 31 Jan 2013 19:31:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568002#comment-13568002
] 

Ted Yu commented on HBASE-7692:
-------------------------------

Please wrap long lines.
{code}
+/** Serializes and deserializes various integer types a sortable, 
{code}
Insert 'into' between 'types' and 'a'
{code}
+ * <p>To use the more efficient serialization format employed by 
+ * <code>IntWritable</code> while avoiding 32-bit truncation, This class 
+ * subclasses <code>IntWritableRowKey</code> to use <code>LongWritable</code>

{code}
The above is not true:
{code}
+public class BigDecimalRowKey extends RowKey 
{code}
{code}
+  protected class ExponentRowKey extends IntWritableRowKey {
{code}
The above class can be private.
{code}
+/** Serializes and deserializes IntWritablesWritables into a sortable 
{code}
Duplicate Writables in IntWritablesWritables
{code}
+public class StringExample
...
+
+public class StructExample
{code}
Add javadoc for the above classes.
                
> Add utility class to generate ordered byte[] serialization
> ----------------------------------------------------------
>
>                 Key: HBASE-7692
>                 URL: https://issues.apache.org/jira/browse/HBASE-7692
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>         Attachments: HBASE-7692.v1.patch
>
>
> The current Bytes utility class works, but produces output that does not maintain the
native sort ordering of the input value. This results in, for example, a negative value that
does not necessarily sort before a positive value. HBase should provide a canonical implementation
of such a serialization format so that third-parties can reliably build on top of HBase. This
will allow an implementation for HIVE-3634, HIVE-2599, or HIVE-2903 that is compatible with
similar features in Pig.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message