hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7660) Remove HFileV1 code
Date Sun, 27 Jan 2013 01:41:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563705#comment-13563705
] 

Hadoop QA commented on HBASE-7660:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12566651/7660-v1.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestStoreFile
                  org.apache.hadoop.hbase.regionserver.TestSplitTransaction
                  org.apache.hadoop.hbase.io.hfile.TestHFileReaderV1

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4202//console

This message is automatically generated.
                
> Remove HFileV1 code
> -------------------
>
>                 Key: HBASE-7660
>                 URL: https://issues.apache.org/jira/browse/HBASE-7660
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck, HFile, migration
>            Reporter: Matt Corgan
>            Assignee: Ted Yu
>             Fix For: 0.96.0
>
>         Attachments: 7660-v1.txt
>
>
> HFileV1 should be removed from the regionserver because it is somewhat of a drag on development
for working on the lower level read paths.  It's an impediment to cleaning up the Store code.
> V1 HFiles ceased to be written in 0.92, but the V1 reader was left in place so users
could upgrade from 0.90 to 0.92.  Once all HFiles are compacted in 0.92, then the V1 code
is no longer needed.  We then decided to leave the V1 code in place in 0.94 so users could
upgrade directly from 0.90 to 0.94.  The code is still there in trunk but should probably
be shown the door.  I see a few options:
> 1) just delete the code and tell people to make sure they compact everything using 0.92
or 0.94
> 2) create a standalone script that people can run on their 0.92 or 0.94 cluster that
iterates the filesystem and prints out any v1 files with a message that the user should run
a major compaction
> 3) add functionality to 0.96.0 (first release, maybe in hbck) that proactively kills
v1 files, so that we can be sure there are none when upgrading from 0.96 to 0.98
> 4) punt to 0.98 and probably do one of the above options in a year
> I would vote for #1 or #2 which will allow us to have a v1-free 0.96.0.  HFileV1 has
already survived 2 major release upgrades which i think many would agree is more than enough
for a pre-1.0, free product.  If we can remove it in 0.96.0 it will be out of the way to introduce
some nice performance improvements in subsequent 0.96.x releases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message