hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7596) Redundant FSTableDescriptor update
Date Thu, 17 Jan 2013 01:30:22 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555729#comment-13555729
] 

Hadoop QA commented on HBASE-7596:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12565222/HBASE-7596-v0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4058//console

This message is automatically generated.
                
> Redundant FSTableDescriptor update
> ----------------------------------
>
>                 Key: HBASE-7596
>                 URL: https://issues.apache.org/jira/browse/HBASE-7596
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 0.96.0, 0.94.4
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>         Attachments: HBASE-7596-v0.patch
>
>
> The TableAddFamilyHandler and TableDeleteFamilyHandler code looks like
> {code}
> // Update table descriptor in HDFS
> HTableDescriptor htd = this.masterServices.getMasterFileSystem()
>     .addColumn(tableName, familyDesc);
> // Update in-memory descriptor cache
> this.masterServices.getTableDescriptors().add(htd);
> {code}
> while the ModifyTableHandler code is just
> {code}
> // Update descriptor
> this.masterServices.getTableDescriptors().add(this.htd);
> {code}
> The MasterFileSystem code looks like
> {code}
> HTableDescriptor htd = this.services.getTableDescriptors().get(tableName);
> // ...add/remove columns to the descriptor...
> this.services.getTableDescriptors().add(htd);
> {code}
> so, the service.getTableDescriptors().add() is called two times for the add/delete family
handler. (and the table descriptor rewritten twice FSTableDescriptors.updateHTableDescriptor())

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message