hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7592) HConnectionManager.getHTableDescriptor() compares too much
Date Wed, 16 Jan 2013 23:02:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555571#comment-13555571
] 

Lars Hofhansl commented on HBASE-7592:
--------------------------------------

+1. Super minor nit: no parentheses needed for return (looks weird, to me)
                
> HConnectionManager.getHTableDescriptor() compares too much
> ----------------------------------------------------------
>
>                 Key: HBASE-7592
>                 URL: https://issues.apache.org/jira/browse/HBASE-7592
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.94.4
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>         Attachments: HBASE-7592-v0.patch
>
>
> in 0.94 getHTableDescriptor() looks at every htd instead of returning at the first found.
(Trunks has already the early exit)
> {code}
> for (HTableDescriptor htd: htds) {
>   if (Bytes.equals(tableName, htd.getName())) {
>     hTableDescriptor = htd;
>   }
> }
> return htableDescriptor
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message