hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7581) TestAccessController depends on the execution order
Date Wed, 16 Jan 2013 17:10:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555220#comment-13555220
] 

Nick Dimiduk commented on HBASE-7581:
-------------------------------------

{code}
-      final List<ThrowableWithExtraContext> exceptions) {
-    super(getMessage(numTries, exceptions));
+                                   final List<ThrowableWithExtraContext> exceptions)
{
+    super(getMessage(numTries, exceptions),
{code}

nit: ws

{code}
     for (Throwable t : exceptions) {
-      buffer.append(t.toString());
+      buffer.append(toString(t));
       buffer.append("\n");
     }
{code}

not: what's the reason for this change? Will {{toString}} avoid an NPE to which {{t.toString()}}
is susceptible?

{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.security.access.TestAccessController
2013-01-16 09:07:57.810 java[47087:1203] Unable to load realm info from SCDynamicStore
Tests run: 34, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.99 sec

Results :

Tests run: 34, Failures: 0, Errors: 0, Skipped: 0
{code}

Looks good to me. nits aside, +1
                
> TestAccessController depends on the execution order
> ---------------------------------------------------
>
>                 Key: HBASE-7581
>                 URL: https://issues.apache.org/jira/browse/HBASE-7581
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>             Fix For: 0.96.0
>
>         Attachments: 7581.v1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message