hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7578) TestCatalogTracker hangs occasionally
Date Wed, 16 Jan 2013 19:46:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555385#comment-13555385
] 

Lars Hofhansl commented on HBASE-7578:
--------------------------------------

It turns out that method called here (waitForMetaServerConnectionDefault) is only called from
tests.
So I simply removed it. In turn we no longer need to keep the defaultTimeout in CatalogTracker...
Also removed. All callers that call waitForMetaServerConnection(long) pass a non-zero value,
so per the previous comments we'll recheck at least every 50ms.

On top of that, some of the callers set the timeout to Long.MAX_VALUE, which in {{ystem.currentTimeMillis()
+ timeout}} would cause an overflow.

So this was a test only problem:
# the test created a CatalogTracker with default timeout set to 0
# it called waitForMetaServerConnectionDefault, which potentially wait forever if the time
is 0

Patch upcoming soon. Testing it now.
                
> TestCatalogTracker hangs occasionally
> -------------------------------------
>
>                 Key: HBASE-7578
>                 URL: https://issues.apache.org/jira/browse/HBASE-7578
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.94.5
>
>         Attachments: 7578-bandaid.txt, 7578-jstack.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message