hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7566) remove useless ctor from HRegion and move sporadic null checks earlier
Date Tue, 15 Jan 2013 02:48:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553433#comment-13553433
] 

Sergey Shelukhin commented on HBASE-7566:
-----------------------------------------

Probably due to test usage in the past... this patch only fixes this minor issue of null checks/dead
code, it doesn't add full validation to HRegion... in fact there's JIRA for that I opened
a while ago :)
                
> remove useless ctor from HRegion and move sporadic null checks earlier
> ----------------------------------------------------------------------
>
>                 Key: HBASE-7566
>                 URL: https://issues.apache.org/jira/browse/HBASE-7566
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-7566-v0.patch
>
>
> Came up while I was doing something for HBASE-7236.
> There are inconsistent null checks in HRegion (few places check, few don't), probably
related to an unused bogus test ctor. Remove ctor, move checks to an earlier location.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message