hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7547) Fix findbugs warnings in snapshot classes
Date Sat, 12 Jan 2013 18:52:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551994#comment-13551994
] 

Jonathan Hsieh commented on HBASE-7547:
---------------------------------------

+1.

I initially thought the \n -> %n was wrong but here's a link to an explanation.  nifty.
http://stackoverflow.com/questions/1883345/whats-up-with-javas-n-in-printf

It is also buried in the docs here under "line separator" http://docs.oracle.com/javase/6/docs/api/java/util/Formatter.html#syntax

nice!
{code}
     FileStatus[] serverLogs = FSUtils.listStatus(fs, logDir, null);
-    if (serverLogs == null) LOG.info("No logs for server directory:" + logDir
-        + ", done referencing files.");
+    if (serverLogs == null) {
+      LOG.debug("No logs for server directory:" + logDir + ", done referencing files.");
+      return null;
+    }
{code}
                
> Fix findbugs warnings in snapshot classes
> -----------------------------------------
>
>                 Key: HBASE-7547
>                 URL: https://issues.apache.org/jira/browse/HBASE-7547
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 7547.txt, findbugsXml.xml
>
>
> Fix findbugs warnings introduced by snapshot code

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message