hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7545) [replication] Break out TestReplication into manageable classes
Date Tue, 29 Jan 2013 20:33:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565772#comment-13565772
] 

Hadoop QA commented on HBASE-7545:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12567040/7545-0.94-v1.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 27 new or modified
tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4238//console

This message is automatically generated.
                
> [replication] Break out TestReplication into manageable classes
> ---------------------------------------------------------------
>
>                 Key: HBASE-7545
>                 URL: https://issues.apache.org/jira/browse/HBASE-7545
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.96.0
>
>         Attachments: 7545-0.94.txt, 7545-0.94-v1.txt, HBASE-7545.patch
>
>
> This has been discussed before but after trying to debug the last failure on Jenkins
where I saw the time go back and forth (if you don't care about your own sanity do checkout
https://builds.apache.org/job/HBase-TRUNK/3726/testReport/junit/org.apache.hadoop.hbase.replication/TestReplicationWithCompression/testDeleteTypes/)
I think it is time to break out TestReplication.
> The difficulty is that the setup for the 2 clusters is a lot of code I don't want to
duplicate. I'm thinking that we can keep {{setUpBeforeClass}} there and have the other classes
extend TestReplication (which should also change name). I'm thinking of the following new
classes:
>  - TestReplicationSmallTests, contains the easy methods that don't mess around too much.
>  - TestReplicationQueueFailover, contains one test of the same name
>  - TestReplicationDisableInactivePeer, contains one test of the same name
>  - Rename TestReplicationWithCompression TestReplicationQueueFailoverWithCompression
and make it extends TestReplicationQueueFailover.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message