hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7536) Add test that confirms that multiple concurrent snapshot requests are rejected.
Date Fri, 11 Jan 2013 17:50:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551318#comment-13551318

Jonathan Hsieh commented on HBASE-7536:

bq. why the test has a timeout? are you expecting things hanging?
are 60sec enough to fill a table and take 5 snapshot, when jenkins is busy with other large

In general if I have code that has a while(true) loop, I make it have a timeout.  The test
finishes in about 10 seconds so giving a timeout of 5-10x seems reasonable.  If it isn't enough,
we can bump it up.

bq. why are you using a thread instead of using the taskSnapshotAsync()? (no particular opinion
on that, I like the thread)

No good reason, I'll change it to the async version on the next rev.

> Add test that confirms that multiple concurrent snapshot requests are rejected.
> -------------------------------------------------------------------------------
>                 Key: HBASE-7536
>                 URL: https://issues.apache.org/jira/browse/HBASE-7536
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-7536.patch, pre-hbase-7536.patch
> Currently the rule is that we can only have online snapshot running at a time.  This
test tries to prove this.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message