hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7503) Add exists(List) in HTableInterface to allow multiple parallel exists at one time
Date Thu, 17 Jan 2013 01:01:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555695#comment-13555695
] 

Sergey Shelukhin commented on HBASE-7503:
-----------------------------------------

bq.  optional bool closestRowBefore = 3;
What's this for? This is not used anywhere; in fact it's not even set in request converter.

bq. If specified, closestRowBefore will be ignored
HRegionServer checks closestRowBefore flag first so existence flag will be ignored instead
if both are specified.

bq. Map<Get, Integer> reference = new HashMap<Get, Integer>();
needs better name.
  
bq.  Bytes.compareTo(get.getRow(), startEndKeys.getSecond()[i]) <= 0)
Just checking; are region boundaries in HBase [] or [)? It would seem that this needs to be
"<" if the latter is the case.


While mapping regions to servers, it may be faster/simpler to sort the input list, and traverse
it in parallel with region start key list.
Or to make a copy, traverse keys list removing gets for each region from gets list. And in
each case, sending the request immediately.
Probably doesn't matter.

bq.  LOG.debug("Failed for gets on region: " + sortedGetEntry.getKey());
warn, like below?


Code for mapping things to stuff (references/indexes/...) is hard to grasp, at least to me.

Maybe it's possible to have array, where for each request there'd be array of ints w/number
of elements equal to the number of gets in the request.
Then one can simply iterate thru responses and insert into corresponding indices in result.
E.g. if gets are [region1-row1, region2-row1, region3-row1, region2-row2] there'd be 3 requests,
and arrays would be [ [ 0 ], [ 1, 3 ], [ 2 ] ]

bq. testHTableExists
Misleading name too.
I'd split the test into smaller tests too (approximately on comment boundaries :)) but that's
a matter of personal preference.

                
> Add exists(List) in HTableInterface to allow multiple parallel exists at one time
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-7503
>                 URL: https://issues.apache.org/jira/browse/HBASE-7503
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Jean-Marc Spaggiari
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch, HBASE-7503-v2-trunk.patch,
HBASE-7503-v2-trunk.patch, HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch, HBASE-7503-v5-trunk.patch,
HBASE-7503-v7-trunk.patch, HBASE-7503-v8-trunk.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> We need to have a Boolean[] exists(List<Get> gets) throws IOException method implemented
in HTableInterface.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message