hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7501) Introduce MetaEditor method that both adds and deletes rows in .META. table
Date Fri, 11 Jan 2013 02:29:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550717#comment-13550717
] 

Hadoop QA commented on HBASE-7501:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12564309/HBASE-7501-v0.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.TestLocalHBaseCluster

     {color:red}-1 core zombie tests{color}.  There are 8 zombie test(s): 	at org.apache.hadoop.hbase.master.TestMasterFailover.testMasterFailoverWithMockedRITOnDeadRS(TestMasterFailover.java:833)

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3972//console

This message is automatically generated.
                
> Introduce MetaEditor method that both adds and deletes rows in .META. table
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7501
>                 URL: https://issues.apache.org/jira/browse/HBASE-7501
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Matteo Bertozzi
>         Attachments: HBASE-7501-v0.patch
>
>
> In review of HBASE-7365, MetaEditor.deleteRegions() and MetaEditor.addRegionsToMeta()
are used in RestoreSnapshotHandler.java.handleTableOperation() to apply changes to .META.
> I made following suggestion:
> Can we introduce new method in MetaEditor which takes List of Mutation's ?
> The Delete and Put would be grouped and then written to .META. table in one transaction.
> Jon responded:
> I like that idea -- then the todo/warning or follow on could refer to that method.  When
we fix it, it could get used in other multi row meta modifications like splits and table creation/deletion
in general.
> See https://reviews.apache.org/r/8674/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message