hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB
Date Mon, 07 Jan 2013 22:20:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546335#comment-13546335
] 

Andrew Purtell commented on HBASE-7414:
---------------------------------------

bq. So, if this test passes, we can have some faith we have not broke our being able to read
hfiles w/ non-pb trailers. Just saying.

Yes this test passes.

bq. Why do the below version test? All files would be written w/ pbs going forward?

Yes. Of course if someone is implementing HFileV3 some day this is free to be changed.

{quote}
-message FileInfoProto {
+message FileInfo
{quote}

Attached updated patch that appends 'Proto' to the PB message names.
                
> Convert some HFile metadata to PB
> ---------------------------------
>
>                 Key: HBASE-7414
>                 URL: https://issues.apache.org/jira/browse/HBASE-7414
>             Project: HBase
>          Issue Type: Task
>          Components: HFile
>            Reporter: stack
>            Assignee: Andrew Purtell
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 7414.patch, 7414.patch, 7414.patch, 7414.patch
>
>
> See HBASE-7201
> Convertion should be in a manner that does not prevent our being able to read old style
hfiles with Writable metadata.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message