hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7414) Convert some HFile metadata to PB
Date Sat, 05 Jan 2013 03:12:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544547#comment-13544547
] 

Ted Yu commented on HBASE-7414:
-------------------------------

{code}
+    if (majorVersion > 2 || (majorVersion == 2 && minorVersion >= PBUF_TRAILER_MINOR_VERSION))
{
...
+  void deserializeFromPB(DataInputStream inputStream) throws IOException {
+    expectMinorVersion(PBUF_TRAILER_MINOR_VERSION);
{code}
expectMinorVersion() only checks minorVersion for equality. So when majorVersion goes to 3,
we shouldn't be checking minorVersion, right ?
                
> Convert some HFile metadata to PB
> ---------------------------------
>
>                 Key: HBASE-7414
>                 URL: https://issues.apache.org/jira/browse/HBASE-7414
>             Project: HBase
>          Issue Type: Task
>          Components: HFile
>            Reporter: stack
>            Assignee: Andrew Purtell
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: 7414.patch
>
>
> See HBASE-7201
> Convertion should be in a manner that does not prevent our being able to read old style
hfiles with Writable metadata.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message