hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7405) Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter user code bits
Date Fri, 04 Jan 2013 22:14:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544295#comment-13544295
] 

Gary Helmling commented on HBASE-7405:
--------------------------------------

Just a couple documentation nits below.  If you fix up these, I'm +1 on the v5 patch.

In ColumnInterpreter, javadoc for getRequestData() needs to be updated for change to initialize()
signature.  Should be:
{noformat}
-   * will pass this to the {@link #initialize(ByteString)}
+   * will pass this to the {@link #initialize(P)}
{noformat}

In AggregateImplementation, add doc for each type parameter in class javadoc:
{noformat}

 /**
  * A concrete AggregateProtocol implementation. Its system level coprocessor
  * that computes the aggregate function at a region level.
+ * {@link ColumnInterpreter} has the explanation for the params.
  * @param <T>
  * @param <S>
+ * @param <P>
+ * @param <Q>
+ * @param <R>
  */
{noformat}
                
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter user code bits
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-7405
>                 URL: https://issues.apache.org/jira/browse/HBASE-7405
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors, Protobufs
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 7405-1.patch, 7405-2.patch, 7405-3.patch, 7405-4.patch, 7405-5.patch
>
>
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter user code bits

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message