hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7369) HConnectionManager should remove aborted connections
Date Thu, 03 Jan 2013 19:44:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543223#comment-13543223

Ted Yu commented on HBASE-7369:

+      else if (connection.isClosed()) {
Move the 'else' line to the end of previous line.
+        close();
         this.closed = true;
When we call close(), this.closed = true would be taken care of inside close(), right ?
+          if(aborted){
+              HConnectionManager.deleteStaleConnection(this);
Please use two spaces for indentation. You can use dev-support/hbase_eclipse_formatter.xml
from trunk.
+  public void abortingHConnectionRemovesItFromHCM() throws Exception{
abortingHConnectionRemovesItFromHCM -> abortingHConnectionRemovesItselfFromHCM
+      Map<HConnectionKey, HConnectionImplementation> oldHBaseInstances = new HashMap<HConnectionKey,
+      for (Entry<HConnectionKey, HConnectionImplementation> entry : HConnectionManager.HBASE_INSTANCES.entrySet()){
Wrap long line: 100 characters per line max
> HConnectionManager should remove aborted connections
> ----------------------------------------------------
>                 Key: HBASE-7369
>                 URL: https://issues.apache.org/jira/browse/HBASE-7369
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 0.94.3
>            Reporter: Bryan Baugher
>            Priority: Minor
>         Attachments: HBASE-7369_HCM-remove-aborted-cnxs.txt, patch2.diff, patch3.diff,
> When an HConnection is abort()'ed (i.e. if numerous services are lost) the connection
becomes unusable. HConnectionManager cache of HConnections currently does not have any logic
around removing aborted connections automatically. Currently it is up to the consumer to do
so using HConnectionManager.deleteStaleConnection(HConnection).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message