hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular
Date Mon, 21 Jan 2013 18:58:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558984#comment-13558984
] 

stack commented on HBASE-7329:
------------------------------

bq. You mean rollWriter? 

I meant the fat log message we make under the log.  Maybe this log could be down outside the
lock?

I think running integration tests a good idea.  The spaghetti locking and state management
that is in place around flush/close and log roll was hard won.  Changing it around may bite
in unexpected ways.

Regards the internal comment, it talks about calling beginOp then you must call...I'm not
sure..... looks like two possibilities.  I was thinking the class comment would include how
you would use the class?  This is a nit.  Not important.

Thanks for persisting w/ this one Sergey.  Its a nice patch.
                
> remove flush-related records from WAL and make locking more granular
> --------------------------------------------------------------------
>
>                 Key: HBASE-7329
>                 URL: https://issues.apache.org/jira/browse/HBASE-7329
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.96.0
>
>         Attachments: 7329-findbugs.diff, HBASE-7329-v0.patch, HBASE-7329-v0.patch, HBASE-7329-v0-tmp.patch,
HBASE-7329-v1.patch, HBASE-7329-v1.patch, HBASE-7329-v2.patch, HBASE-7329-v3.patch, HBASE-7329-v4.patch,
HBASE-7329-v5.patch
>
>
> Comments from many people in HBASE-6466 and HBASE-6980 indicate that flush records in
WAL are not useful. If so, they should be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message