hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7329) remove flush-related records from WAL and make locking more granular
Date Fri, 18 Jan 2013 05:12:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556969#comment-13556969
] 

Ted Yu commented on HBASE-7329:
-------------------------------

Was this part of code changed due to the following findbugs warning ?
{code}
  <BugInstance type="IS2_INCONSISTENT_SYNC" priority="2" abbrev="IS" category="MT_CORRECTNESS">
    <Class classname="org.apache.hadoop.hbase.regionserver.wal.FSHLog">
      <SourceLine classname="org.apache.hadoop.hbase.regionserver.wal.FSHLog" start="108"
end="1424" sourcefile="FSHLog.java" sourcepath="org/apache/hadoop/hbase/regionserver/wal/FSHLog.java"/>
    </Class>
    <Field classname="org.apache.hadoop.hbase.regionserver.wal.FSHLog" name="writer" signature="Lorg/apache/hadoop/hbase/regionserver/wal/HLog$Writer;"
isStatic="false">
      <SourceLine classname="org.apache.hadoop.hbase.regionserver.wal.FSHLog" sourcefile="FSHLog.java"
sourcepath="org/apache/hadoop/hbase/regionserver/wal/FSHLog.java"/>
    </Field>
{code}
Such warning appears in AuthenticationTokenSecretManager, etc.
                
> remove flush-related records from WAL and make locking more granular
> --------------------------------------------------------------------
>
>                 Key: HBASE-7329
>                 URL: https://issues.apache.org/jira/browse/HBASE-7329
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.96.0
>
>         Attachments: 7329-findbugs.diff, HBASE-7329-v0.patch, HBASE-7329-v0.patch, HBASE-7329-v0-tmp.patch,
HBASE-7329-v1.patch, HBASE-7329-v1.patch, HBASE-7329-v2.patch, HBASE-7329-v3.patch, HBASE-7329-v4.patch
>
>
> Comments from many people in HBASE-6466 and HBASE-6980 indicate that flush records in
WAL are not useful. If so, they should be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message