hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7253) Compaction Tool
Date Sat, 05 Jan 2013 00:44:56 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544457#comment-13544457
] 

Hudson commented on HBASE-7253:
-------------------------------

Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/])
    HBASE-7253 Backport Compaction Tool to 0.94; REVERT (Revision 1417740)
HBASE-7253 Backport Compaction Tool to 0.94; includes HBASE-5616, HBASE-5693, HBASE-6327,
HBASE-7253 (Revision 1417559)

     Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Compactor.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java

stack : 
Files : 
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactionTool.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Compactor.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionProgress.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/ChecksumType.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java

                
> Compaction Tool
> ---------------
>
>                 Key: HBASE-7253
>                 URL: https://issues.apache.org/jira/browse/HBASE-7253
>             Project: HBase
>          Issue Type: New Feature
>          Components: Compaction
>    Affects Versions: 0.96.0
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7253-v0.patch, HBASE-7253-v1.patch
>
>
> In HBASE-5616, as part of the compaction code refactor, a CompactionTool was added.
> but there are some issues:
> * The tool is under test/
> * mockito is required, so the "test" scope should be removed from the pom.xml, otherwise
the tool doesn't start
> * The mock, used by the tool, is mocking HRegion.getRegionInfo() but some code (Store)
uses HRegion.regionInfo directly HStore.java#L2021,  HStore.java#L1389, HStore.java#L1402
and you end up with a NPE in the tool.
> * The Mocked Store uses a dummy family and the compacted files doesn't get the same family
properties specified (compression, encoding, ...)
> * at the end of compaction CompactionTool.java#L155, on by default, the compaction file
is removed (note that the compacted one are already removed inside the store.compact()...
and you end up with an empty dir, if you compact everything.
> I've fixed some stuff and added support to:
>  * Run the compaction as a MR Job
>  * Specify a Table (compact each region/family)
>  * Specify a Region (compact each family)
>  * Specify a Family (as before)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message