hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6521) Address the handling of multiple versions of a protocol
Date Wed, 02 Jan 2013 00:18:12 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack updated HBASE-6521:
-------------------------

    Attachment: pbservice.txt

This patch has hackup to make MasterProtocol, the isMasterRunning method,
work by hooking up the generated protobuf Service to our rpc.
It also messes with TestProtoBufRpcServer test class hooking up
a "protocol" to use protobuf Services instead.  It does not remove
VersionedProtocol though it is being bypassed in this patch.  We do
not remove it because it would bulk up the patch.
* MasterAdminProtocol
* MasterMonitorProtocol
  Remove code copied from generated protobuf BlockingInterface
* MasterProtocol removed; just use the generated pb Interface instead.
* HConnectionManager This class has some hackery making the call
  isMasterRunning.  Instead of asking HBaseClientRPC for a proxy,
  we instead ask for a pb RpcChannel so we can make a Stub for the
  client to use.  The RpcController goes unused/unexploited.
* HBaseClient Allow for now a 'null' proxy.  This is how we indicate
  a protobuf Service.  Would need to be fixed so we pass actual
  Service name. 
* ProtobufRpcClientEnging We make a BlockingRpcChannel.  Knows
  how to do the call against the server.  Added a getChannel
  call which is like doing a getProxy.  Refactored call to
  use the stub if present.  Why we have interfaces and protocol?
  Seems broke.  Needs cleanup.
* TestProtoBufRpc Pulled this test around to mess with
  protobuf Service.
                
> Address the handling of multiple versions of a protocol
> -------------------------------------------------------
>
>                 Key: HBASE-6521
>                 URL: https://issues.apache.org/jira/browse/HBASE-6521
>             Project: HBase
>          Issue Type: Improvement
>          Components: IPC/RPC
>            Reporter: Devaraj Das
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: pbservice.txt
>
>
> This jira is to track a solution/patch to the mailing list thread titled "Handling protocol
versions" - http://search-hadoop.com/m/6k7GUM028E/v=threaded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message