hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6386) Audit log messages do not include column family / qualifier information consistently
Date Tue, 08 Jan 2013 21:28:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547292#comment-13547292
] 

Hadoop QA commented on HBASE-6386:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12563803/HBASE-6386-v4.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3936//console

This message is automatically generated.
                
> Audit log messages do not include column family / qualifier information consistently
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-6386
>                 URL: https://issues.apache.org/jira/browse/HBASE-6386
>             Project: HBase
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.96.0
>            Reporter: Marcelo Vanzin
>         Attachments: hbase-6386-v1.patch, hbase-6386-v2.patch, HBASE-6386-v3.patch, HBASE-6386-v4.patch
>
>
> The code related to this issue is in AccessController.java:permissionGranted().
> When creating audit logs, that method will do one of the following:
> * grant access, create audit log with table name only
> * deny access because of table permission, create audit log with table name only
> * deny access because of column family / qualifier permission, create audit log with
specific family / qualifier
> So, in the case where more than one column family and/or qualifier are in the same request,
there will be a loss of information. Even in the case where only one column family and/or
qualifier is involved, information may be lost.
> It would be better if this behavior consistently included all the information in the
request; regardless of access being granted or denied, and regardless which permission caused
the denial, the column family and qualifier info should be part of the audit log message.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message