Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 11 Dec 2012 06:43:21 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12623173.1355159732049.16397.1355208201191@arcas>
In-Reply-To: <JIRA.12623173.1355159732049@arcas>
References: <JIRA.12623173.1355159732049@arcas>
Subject: [jira] [Commented] (HBASE-7313) ColumnPaginationFilter should reset
 count when moving to NEXT_ROW
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528729#comment-13528729 ] 

Anoop Sam John commented on HBASE-7313:
---------------------------------------

Varun
     Jieshan is correct. There is no need to do this change. The reset of the count is happening in the reset() method. This method will be invoked before fetching any new row. RegionScannerImpl#resetFilters() u can see.
When the count reaches the limit the Filter returns NEXT_ROW. This indicates a completion of KVs from the current row. And so the StoreScanner(s) wont continue with the scan within this row. Also it will make a seek to the end of this row. Here it is done with the fetching of KVs for this row. Again the control will be back to the HRS and from there the next row fetch begins (If you have caching>1). Here initially itself the reset will be called on the filters.

I think you can close this issue. BTW have u faced some issues with the current code? Mind telling it if any?
                
> ColumnPaginationFilter should reset count when moving to NEXT_ROW
> -----------------------------------------------------------------
>
>                 Key: HBASE-7313
>                 URL: https://issues.apache.org/jira/browse/HBASE-7313
>             Project: HBase
>          Issue Type: Bug
>          Components: Filters
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Varun Sharma
>            Assignee: Varun Sharma
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7313-0.94.txt, 7313-trunk.txt
>
>
> ColumnPaginationFilter does not reset count to zero on moving to next row. Hence, if we have already gotten "limit" number of columns - the subsequent rows will always return 0 columns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira