Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 8 Dec 2012 02:29:21 +0000 (UTC)
From: "Andrew Purtell (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12622989.1354924539452.6922.1354933761498@arcas>
In-Reply-To: <JIRA.12622989.1354924539452@arcas>
References: <JIRA.12622989.1354924539452@arcas>
Subject: =?utf-8?Q?[jira]_[Commented]_(HBASE-7303)_Quit_using_reflection_?=
 =?utf-8?Q?for_the_method_DFSOutputStream#getNumCurrentReplicas(=E2=80=A6)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HBASE-7303?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1352=
6993#comment-13526993 ]=20

Andrew Purtell commented on HBASE-7303:
---------------------------------------

FSHLog is where we pull out FS specific logic, so my vote would be to move =
FSHLog to the compat modules, so version specific reflection can be convert=
ed into direct method calls, and leave HLog in hbase-server.=C2=A0
               =20
> Quit using reflection for the method DFSOutputStream#getNumCurrentReplica=
s(=E2=80=A6)
> -------------------------------------------------------------------------=
----
>
>                 Key: HBASE-7303
>                 URL: https://issues.apache.org/jira/browse/HBASE-7303
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Minor
>
> Given that we've raised our minimum version guarantee for HBase with 1.x =
carrying the 0.20-append code finally, and all subsequent releases (0.21*, =
0.22, 0.23 and 2) have this method available in them, I don't see a reason =
to have the reflection based getNumCurrentReplicas invocation (via HDFS-826=
) anymore.
> We could save ourselves quite a bit of perf. penalty by removing this che=
ck and simply calling the method directly, as its API has not changed acros=
s releases.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira