Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 25 Dec 2012 14:26:13 +0000 (UTC)
From: "Matteo Bertozzi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12622833.1354837763588.51008.1356445573513@arcas>
In-Reply-To: <JIRA.12622833.1354837763588@arcas>
References: <JIRA.12622833.1354837763588@arcas>
Subject: [jira] [Updated] (HBASE-7294) Check for snapshot file cleaners on
 start
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Bertozzi updated HBASE-7294:
-----------------------------------

    Attachment: HBASE-7294-v5.patch

v5 patch applies on jesse branch
added also "hbase.snapshot.enabled" property and it works like this:
 * No "hbase.snapshot.enabled" in the config
 ** If cleaners are enabled snapshot feature is enabled
 ** If cleaners are not enabled
 *** if there're no snapshot in the .snapshot folder, snapshot feature is disabled
 *** if there're snapshot in the .snapshot folder, an exception was raised to avoid to start the master and throw away the .snapshot present
 * "hbase.snapshot.enabled" is true in the config
 ** Force the snapshot cleaners to be in and enable the feature
 * "hbase.snapshot.enabled" is false in the config
 ** The feature is disabled but if cleaners are not enabled and there're snapshot in the .snapshot folder, an exception was raised to avoid to start the master and throw away the .snapshot present
                
> Check for snapshot file cleaners on start
> -----------------------------------------
>
>                 Key: HBASE-7294
>                 URL: https://issues.apache.org/jira/browse/HBASE-7294
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, master, regionserver, snapshots, Zookeeper
>    Affects Versions: hbase-6055
>            Reporter: Jesse Yates
>            Assignee: Matteo Bertozzi
>             Fix For: hbase-6055, 0.96.0
>
>         Attachments: HBASE-7294-v1.patch, HBASE-7294-v2.patch, HBASE-7294-v3.patch, HBASE-7294-v4.patch, HBASE-7294-v5.patch
>
>
> Snapshots currently use the SnaphotHfileCleaner and SnapshotHLogCleaner to ensure that any hfiles or hlogs (respectively) that are currently part of a snapshot are not removed from their respective archive directories (.archive and .oldlogs).
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the user doesn't remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the cleaner is not enabled?
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira