Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A711E65D for ; Sun, 16 Dec 2012 11:10:14 +0000 (UTC) Received: (qmail 96269 invoked by uid 500); 16 Dec 2012 11:10:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 96172 invoked by uid 500); 16 Dec 2012 11:10:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 96136 invoked by uid 99); 16 Dec 2012 11:10:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Dec 2012 11:10:12 +0000 Date: Sun, 16 Dec 2012 11:10:12 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-7174) [snapshots] Refactor snapshot file cleaner cache to use the Snapshot FileVisitor MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-7174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533354#comment-13533354 ] Hadoop QA commented on HBASE-7174: ---------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561180/HBASE-7174-v0.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 6 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3564//console This message is automatically generated. > [snapshots] Refactor snapshot file cleaner cache to use the Snapshot FileVisitor > -------------------------------------------------------------------------------- > > Key: HBASE-7174 > URL: https://issues.apache.org/jira/browse/HBASE-7174 > Project: HBase > Issue Type: Sub-task > Affects Versions: hbase-6055 > Reporter: Jesse Yates > Assignee: Matteo Bertozzi > Attachments: HBASE-7174-v0.patch > > > Currently the SnapshotFileCache uses a generic PathFilter to filter out directories when caching objects. This is a little more convoluted that is necessary as one needs a very thorough understanding of both the directory layout of a snapshot and how the cache applies the filter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira