Return-Path: 
 <issues-return-70297-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7300FEF31
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed,  5 Dec 2012 03:37:03 +0000 (UTC)
Received: (qmail 64061 invoked by uid 500); 5 Dec 2012 03:37:02 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 63952 invoked by uid 500); 5 Dec 2012 03:37:02 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 63273 invoked by uid 99); 5 Dec 2012 03:37:00 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2012 03:37:00 +0000
Date: Wed, 5 Dec 2012 03:37:00 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1664561756.61918.1354678620273.JavaMail.jiratomcat@arcas>
In-Reply-To: <1259445436.14891.1353541378105.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-7205) Coprocessor classloader is
 replicated for all regions in the HRegionServer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510241#comment-13510241 ] 

Ted Yu commented on HBASE-7205:
-------------------------------

{code}
+        classLoaders.add(cl);
{code}
I only found one reference to classLoaders, shown above. I wonder what purpose classLoaders would serve.
{code}
+  protected Set<ClassLoader> classLoaders = new HashSet<ClassLoader>();
+  static ConcurrentMap<Path, ClassLoader> classLoadersCache = new MapMaker()
{code}
Shouldn't the above be declared as static ? (CoprocessorHost is per-region).

I think we can unload ClassLoader from the cache using DeleteTableHandler and DisableTableHandler.
The assumption is that different tables have different schemas. Coprocessor for one table wouldn't directly fit another table.
                
> Coprocessor classloader is replicated for all regions in the HRegionServer
> --------------------------------------------------------------------------
>
>                 Key: HBASE-7205
>                 URL: https://issues.apache.org/jira/browse/HBASE-7205
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.92.2, 0.94.2
>            Reporter: Adrian Muraru
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7205-v1.txt, HBASE-7205_v2.patch
>
>
> HBASE-6308 introduced a new custom CoprocessorClassLoader to load the coprocessor classes and a new instance of this CL is created for each single HRegion opened. This leads to OOME-PermGen when the number of regions go above hundres / region server. 
> Having the table coprocessor jailed in a separate classloader is good however we should create only one for all regions of a table in each HRS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira