Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D8A4EE035 for ; Tue, 4 Dec 2012 03:03:59 +0000 (UTC) Received: (qmail 70032 invoked by uid 500); 4 Dec 2012 03:03:59 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 69981 invoked by uid 500); 4 Dec 2012 03:03:59 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 69961 invoked by uid 99); 4 Dec 2012 03:03:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Dec 2012 03:03:59 +0000 Date: Tue, 4 Dec 2012 03:03:59 +0000 (UTC) From: "Nick Dimiduk (JIRA)" To: issues@hbase.apache.org Message-ID: <1355468991.57278.1354590239402.JavaMail.jiratomcat@arcas> In-Reply-To: <1485365482.112133.1343429194981.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6469) Failure on enable/disable table will cause table state in zk to be left as enabling/disabling until master is restart MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509468#comment-13509468 ] Nick Dimiduk commented on HBASE-6469: ------------------------------------- I don't think review board is cross-posting. https://reviews.apache.org/r/8333/ > Failure on enable/disable table will cause table state in zk to be left as enabling/disabling until master is restart > --------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-6469 > URL: https://issues.apache.org/jira/browse/HBASE-6469 > Project: HBase > Issue Type: Bug > Affects Versions: 0.94.2, 0.96.0 > Reporter: Enis Soztutar > Assignee: Nick Dimiduk > Fix For: 0.96.0, 0.94.4 > > > In Enable/DisableTableHandler code, if something goes wrong in handling, the table state in zk is left as ENABLING / DISABLING. After that we cannot force any more action from the API or CLI, and the only recovery path is restarting the master. > {code} > if (done) { > // Flip the table to enabled. > this.assignmentManager.getZKTable().setEnabledTable( > this.tableNameStr); > LOG.info("Table '" + this.tableNameStr > + "' was successfully enabled. Status: done=" + done); > } else { > LOG.warn("Table '" + this.tableNameStr > + "' wasn't successfully enabled. Status: done=" + done); > } > {code} > Here, if done is false, the table state is not changed. There is also no way to set skipTableStateCheck from cli / api. > We have run into this issue a couple of times before. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira