hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Dimiduk (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-7428) There are multiple HConstants for configuring Zookeeper timeout
Date Wed, 26 Dec 2012 19:30:12 GMT

     [ https://issues.apache.org/jira/browse/HBASE-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nick Dimiduk updated HBASE-7428:
--------------------------------

    Attachment: 7428-consolidate-ZK_SESSION_TIMEOUT.0.diff

This patch consolidates on {{ZK_SESSION_TIMEOUT}}, replaces string literals and default value
literals with references to {{HConstants}}.

After applying this patch, no more occurrences of {{zookeeper.session.timeout}} are found:

{code}
$ grep -riIn 'zookeeper\.session\.timeout' */src/*
hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java:173:  public static final
String ZK_SESSION_TIMEOUT = "zookeeper.session.timeout";
hbase-server/src/main/resources/hbase-default.xml:619:    <name>zookeeper.session.timeout</name>
{code}
                
> There are multiple HConstants for configuring Zookeeper timeout
> ---------------------------------------------------------------
>
>                 Key: HBASE-7428
>                 URL: https://issues.apache.org/jira/browse/HBASE-7428
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nick Dimiduk
>            Priority: Minor
>              Labels: noob
>         Attachments: 7428-consolidate-ZK_SESSION_TIMEOUT.0.diff
>
>
> From [~tedyu@apache.org] to dev@:
> {quote}
> There are two constants with the same value:
> HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT
> HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests.
> HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil
> Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use
> HConstants.ZK_SESSION_TIMEOUT ?
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message