hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7417) TestReplication is flaky
Date Fri, 21 Dec 2012 10:35:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537792#comment-13537792

nkeywal commented on HBASE-7417:

A slow non flaky test is better than a fast flaky test :-).
But the problem with launching a cluster in each test method is that then the test method
tends to grow to include multiples smalls tests. TestMasterFailover is for example very difficult
to understand because of this: the test methods are 100 lines each. And trying to fix it later
is difficult. I tried and finally failed on TestMasterFailover.

So in the general case, I think the best pattern is a single cluster start/stop per class
test, this makes having small & clear test methods natural.

Again, I'm quite happy to learn that TestReplication is now non flaky, that's a lovely progress.
Just that for new tests we should not do that :-).
> TestReplication is flaky
> ------------------------
>                 Key: HBASE-7417
>                 URL: https://issues.apache.org/jira/browse/HBASE-7417
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 0.96.0, 0.94.4
>         Attachments: 7417-0.94.txt, 7417-0.96.txt
> See discussion at the end of HBASE-5778.
> TestReplication failed in all recent 0.94 jenkins builds.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message