hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raymond Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7387) StoreScanner need to be able to be subclassed
Date Thu, 20 Dec 2012 02:59:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536724#comment-13536724
] 

Raymond Liu commented on HBASE-7387:
------------------------------------


The testing results seems non relevant to this patch.

And, btw, first time to come across this patch testing system, thus a few questions :
1. Where to justify no new tests are needed? In "submit patch"'s comment field? Is that needed
for every patch that do not need new tests?
2. How to efficiently go through the auto testing result? Is there always non relevant info
in it?

Thx.
                
> StoreScanner need to be able to be subclassed
> ---------------------------------------------
>
>                 Key: HBASE-7387
>                 URL: https://issues.apache.org/jira/browse/HBASE-7387
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.96.0
>            Reporter: Raymond Liu
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: HBASE_7387_v2.patch, StoreScanner.patch
>
>
> StoreScanner can be replaced by preStoreScannerOpen hook with CP. In order to reuse most
of the logic in current StoreScanner, subclass it might be the best approaching. Thus a lot
of private member need to be changed from private to protected.
> At present, in order to to implement a custom storescanner for dot (HBASE-6805), only
a few of the private member need to be changed as in the attached storescanner.patch, while
should we change all the reasonable field from private to protected as in HBASE-7387-v?.patch

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message