hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7340) Master coprocessor notification for assignmentManager.balance() is inconsistent
Date Thu, 13 Dec 2012 20:56:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531495#comment-13531495
] 

Hadoop QA commented on HBASE-7340:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12560837/7340-v2.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 104 warning
messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 23 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3533//console

This message is automatically generated.
                
> Master coprocessor notification for assignmentManager.balance() is inconsistent
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-7340
>                 URL: https://issues.apache.org/jira/browse/HBASE-7340
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Trivial
>         Attachments: 7340-v1.txt, 7340-v2.txt
>
>
> I found this issue when reading user discussion which is quoted below.
> In HMaster.moveRegion(), we have:
> {code}
>       this.assignmentManager.balance(rp);
>       if (this.cpHost != null) {
>         this.cpHost.postMove(hri, rp.getSource(), rp.getDestination());
>       }
> {code}
> Meaning, user can register master coprocessor which would receive region movement notification.
> The assignmentManager.balance(plan) call in HMaster.balance() doesn't send out such notification.
> I think we should enhance the following hook (at line 1335) with list of regions moved
so that notification from master is consistent:
> {code}
>         this.cpHost.postBalance();
> {code}
> Here is excerpt for user discussion:
> Sometimes user performs compaction after a region is moved (by balancer). We should provide
'hook' which lets user specify what follow-on actions to take after region movement.
> See discussion on user mailing list under the thread 'How to know it's time for a major
compaction?' for background information: http://search-hadoop.com/m/BDx4S1jMjF92&subj=How+to+know+it+s+time+for+a+major+compaction+

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message