hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7295) Contention in HBaseClient.getConnection
Date Mon, 10 Dec 2012 17:35:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528088#comment-13528088
] 

Hadoop QA commented on HBASE-7295:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12560210/7295-trunk-v2.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 101 warning
messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 23 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.regionserver.TestSplitTransaction

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3474//console

This message is automatically generated.
                
> Contention in HBaseClient.getConnection
> ---------------------------------------
>
>                 Key: HBASE-7295
>                 URL: https://issues.apache.org/jira/browse/HBASE-7295
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.94.3
>            Reporter: Varun Sharma
>            Assignee: Varun Sharma
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7295-0.94.txt, 7295-0.94-v2.txt, 7295-0.94-v3.txt, 7295-0.94-v4.txt,
7295-trunk.txt, 7295-trunk.txt, 7295-trunk-v2.txt
>
>
> HBaseClient.getConnection() synchronizes on the connections object. We found severe contention
on a thrift gateway which was fanning out roughly 3000+ calls per second to hbase region servers.
The thrift gateway had 2000+ threads for handling incoming connections. Threads were blocked
on the syncrhonized block - we set ipc.pool.size to 200. Since we are using RoundRobin/ThreadLocal
pool only - its not necessary to synchronize on connections - it might lead to cases where
we might go slightly over the ipc.max.pool.size() but the additional connections would timeout
after maxIdleTime - underlying PoolMap connections object is thread safe.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message