hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7294) Check for snapshot file cleaners on start
Date Mon, 17 Dec 2012 02:30:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533605#comment-13533605
] 

Jesse Yates commented on HBASE-7294:
------------------------------------

[~mbertozzi] good on ya for taking this! What do you think about flipping the order of setup
and checking for the cleaners on master startup in SnapshtManager#start()? 

There you could (1) set a boolean flag there if snapshots are allowed and (2) also check the
on-disk state and throw an exception if the cleaners aren't enabled. This helps keep the encapsulation
around snapshot management in the SnapshotManager and seems a cleaner place to do checking
for allowing a snapshot operation rather than in the HMaster (similar to how we check if other
snapshots are already running).
                
> Check for snapshot file cleaners on start
> -----------------------------------------
>
>                 Key: HBASE-7294
>                 URL: https://issues.apache.org/jira/browse/HBASE-7294
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, master, regionserver, snapshots, Zookeeper
>    Affects Versions: hbase-6055
>            Reporter: Jesse Yates
>            Assignee: Matteo Bertozzi
>             Fix For: hbase-6055, 0.96.0
>
>         Attachments: HBASE-7294-v0.patch
>
>
> Snapshots currently use the SnaphotHfileCleaner and SnapshotHLogCleaner to ensure that
any hfiles or hlogs (respectively) that are currently part of a snapshot are not removed from
their respective archive directories (.archive and .oldlogs).
> From Matteo Bertozzi:
> {quote}
> currently the snapshot cleaner is not in hbase-default.xml
> and there's no warning/exception on snapshot/restore operation, if not enabled.
> even if we add the cleaner to the hbase-default.xml how do we ensure that the user doesn't
remove it?
> Do we want to hardcode the cleaner at master startup?
> Do we want to add a check in snapshot/restore that throws an exception if the cleaner
is not enabled?
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message