hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7283) Backport HBASE-6564 + HBASE-7202 to 0.94
Date Tue, 18 Dec 2012 20:58:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535305#comment-13535305
] 

stack commented on HBASE-7283:
------------------------------

Took a look at hbase-7202.  It doesn't look like it was backported to 0.94.  I updated hbase-7202
accordingly.

The hbase-7202 patch attached here does not apply:

{code}
  1 ***************
  0 *** 456,465 ****                                                                     
                                                                                         
                        
  1 ..  
  2     public void deleteFamilyFromFS(HRegionInfo region, byte[] familyName)            
            
  3         throws IOException {
  4 -     Path delDir = new Path(rootdir,
  5 -         new Path(region.getTableNameAsString(), new Path(
  6 -             region.getEncodedName(), new Path(Bytes.toString(familyName)))));      
            
  7 -     if (fs.delete(delDir, true) == false) {                                        
            
  8         throw new IOException("Could not delete family "                             
            
  9             + Bytes.toString(familyName) + " from FileSystem for region "            
            
 10             + region.getRegionNameAsString() + "(" + region.getEncodedName()         
            
 11 --- 456,469 ----
 12 ..  
 13     public void deleteFamilyFromFS(HRegionInfo region, byte[] familyName)            
            
 14         throws IOException {                                                         
            
 15 +     // archive family store files                                                  
            
 16 +     Path tableDir = new Path(rootdir, region.getTableNameAsString());              
            
 17 +     HFileArchiver.archiveFamily(fs, conf, region, tableDir, familyName);           
            
 18 +.
 19 +     // delete the family folder
 20 +     Path familyDir = new Path(tableDir,                                            
            
 21 +       new Path(region.getEncodedName(), Bytes.toString(familyName)));              
            
 22 +     if (fs.delete(familyDir, true) == false) {                                     
            
 23         throw new IOException("Could not delete family "
 24             + Bytes.toString(familyName) + " from FileSystem for region "            
            
 25             + region.getRegionNameAsString() + "(" + region.getEncodedName()    
{code}


Mind taking a looksee Mr. Matteo?  The deleteFamily* method is not in 0.94.


                
> Backport HBASE-6564 + HBASE-7202 to 0.94
> ----------------------------------------
>
>                 Key: HBASE-7283
>                 URL: https://issues.apache.org/jira/browse/HBASE-7283
>             Project: HBase
>          Issue Type: Task
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 0.94.4
>
>         Attachments: HBASE-6564-0.94.patch, HBASE-7202-0.94.patch
>
>
> * HBASE-6564: HDFS space is not reclaimed when a column family is deleted
> * HBASE-7202: Family Store Files are not archived on admin.deleteColumn()
> (the second one is a fix for the first, to use the archiver)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message