hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-7271) Have a single executor for all zkWorkers in the assignment manager
Date Fri, 07 Dec 2012 15:31:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-7271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526454#comment-13526454
] 

nkeywal commented on HBASE-7271:
--------------------------------

v3. Testing locally. 
All comments above taken into account, excepted:
bq. The check in the below should be under the synchronization block too...
The code as it is is ok imho?

bq. On commit, probably set the iterator to a local variable, and call iterator.remove() instead.
Guava should return something nicer than a simple Set, so it's not perfect whatever we do...
I added some comments and renamed a variable.

                
> Have a single executor for all zkWorkers in the assignment manager
> ------------------------------------------------------------------
>
>                 Key: HBASE-7271
>                 URL: https://issues.apache.org/jira/browse/HBASE-7271
>             Project: HBase
>          Issue Type: Bug
>          Components: master, Region Assignment
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Assignee: nkeywal
>             Fix For: 0.96.0
>
>         Attachments: 7271.v1.patch, 7271.v2.patch, 7271.v2.patch, 7271.v3.patch
>
>
> The current strategy is to have an array of monothreaded executor, and hash the zk path
to ensure that there are no two events on the same region executed in parallel  
> I think a single executor, as presented in the attached patch, is better because:
> - we're guaranteed to use all threads at any time
> - if managing one of the event takes longer that expected, the slowness is limited to
this region, and not to all regions that have the same hashed/moduloed code
> - For the nodeChildrenChanged, there is no need to choose randomly one of the worker
(or, once again, the risk to get stuck if one of the event takes time to be managed).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message