hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6585) Audit log messages should contain info about the higher level operation being executed
Date Tue, 18 Dec 2012 13:28:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534882#comment-13534882
] 

Hadoop QA commented on HBASE-6585:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12561471/HBASE-6585-v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 26 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.catalog.TestMetaReaderEditor

     {color:red}-1 core zombie tests{color}.  There are zombie tests. See build logs for details.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3582//console

This message is automatically generated.
                
> Audit log messages should contain info about the higher level operation being executed
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-6585
>                 URL: https://issues.apache.org/jira/browse/HBASE-6585
>             Project: HBase
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 0.96.0
>            Reporter: Marcelo Vanzin
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>              Labels: acl
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: HBASE-6585-v0.patch, HBASE-6585-v1.patch, HBASE-6585-v2.patch
>
>
> Currently, audit log messages contains the "action" for which access was checked; this
is one of READ, WRITE, CREATE or ADMIN.
> These give very little information to the person digging into the logs about what was
done, though. You can't ask "who deleted rows from table x?", because "delete" is translated
to a "WRITE" action.
> It would be nice if the audit logs contained the higher-level operation, either replacing
or in addition to the RWCA information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message