hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6317) Master clean start up and Partially enabled tables make region assignment inconsistent.
Date Sun, 09 Dec 2012 22:15:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527644#comment-13527644
] 

Ted Yu commented on HBASE-6317:
-------------------------------

Integrated to 0.94 branch.

Thanks for the patch, Rajesh.

0.94 patch doesn't apply to 0.92:
{code}
6 out of 10 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java.rej
(Stripping trailing CRs from patch.)
patching file src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
Hunk #10 FAILED at 202.
Hunk #11 FAILED at 210.
2 out of 11 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java.rej
(Stripping trailing CRs from patch.)
patching file src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
Hunk #1 succeeded at 63 with fuzz 2 (offset -11 lines).
Hunk #2 FAILED at 81.
Hunk #3 FAILED at 762.
Hunk #4 succeeded at 337 with fuzz 2 (offset -573 lines).
Hunk #5 succeeded at 452 (offset -573 lines).
2 out of 5 hunks FAILED -- saving rejects to file src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java.rej
{code}
                
> Master clean start up and Partially enabled tables make region assignment inconsistent.
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-6317
>                 URL: https://issues.apache.org/jira/browse/HBASE-6317
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: rajeshbabu
>             Fix For: 0.92.3, 0.96.0, 0.94.4
>
>         Attachments: HBASE-6317_94_3.patch, HBASE-6317_94_4.patch, HBASE-6317_94.patch,
HBASE-6317_trunk_2.patch, HBASE-6317_trunk_3.patch, HBASE-6317_trunk_4.patch, HBASE-6317_trunk_5.patch
>
>
> If we have a  table in partially enabled state (ENABLING) then on HMaster restart we
treat it as a clean cluster start up and do a bulk assign.  Currently in 0.94 bulk assign
will not handle ALREADY_OPENED scenarios and it leads to region assignment problems.  Analysing
more on this we found that we have better way to handle these scenarios.
> {code}
> if (false == checkIfRegionBelongsToDisabled(regionInfo)
>             && false == checkIfRegionsBelongsToEnabling(regionInfo)) {
>           synchronized (this.regions) {
>             regions.put(regionInfo, regionLocation);
>             addToServers(regionLocation, regionInfo);
>           }
> {code}
> We dont add to regions map so that enable table handler can handle it.  But as nothing
is added to regions map we think it as a clean cluster start up.
> Will come up with a patch tomorrow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message