hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Chanan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6039) Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
Date Sat, 29 Dec 2012 00:54:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540692#comment-13540692
] 

Gregory Chanan commented on HBASE-6039:
---------------------------------------

Are you interested in MasterProtocol in particular or the general structure of the above,
which is present in MasterMonitorProtocol, AdminProtocol, etc?  I'm going to answer in general;
MasterProtocol in particular is explained on the reviewboard: https://reviews.apache.org/r/5652/
(See: "MasterProtocol is a subset of whats possible?  Its just the basic version and is master
running?").

bq. Was wondering why you implemented BlockingInterface in the below G:
bq. I'm trying to figure out if any particular reason for the protocol definitions we have.
Above we have mention of RpcController but everywhere it comes up we just null it out. Was
it just there transitionally or did you find you needed it? (Sorry to be asking this long
after commit). Thanks.

It's just to use the function definitions that protobuf generates from the "service" declaration
in the .proto files.  That way the rpc structure (function name, return and param types) are
defined in the proto files.  We don't need RpcController; protobuf just generates it that
way.  Certainly for our purposes we could just write our own; not sure if that would make
clients in other languages more difficult to write.


bq. Also, why if we are implementing BlockingInterface, would you include here the isMasterRunning
method since it is back in BlockingInterface anyways, right?
It's just to have a javadoc comment associated with the function because you can't force protobuf
to generate them.
                
> Remove HMasterInterface and replace with something similar to RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-6039
>                 URL: https://issues.apache.org/jira/browse/HBASE-6039
>             Project: HBase
>          Issue Type: Task
>          Components: IPC/RPC, master
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6039.patch, HBASE-6039-v2.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either declare
a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose
HMasterInterface for that. What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message