Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 11 Nov 2012 23:51:12 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <691538931.98825.1352677872629.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <1149297678.28393.1322694819919.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495051#comment-13495051 ] 

Lars Hofhansl commented on HBASE-4913:
--------------------------------------

Patch looks good +1 (for 0.94.3 if committed soon).

Minor nit:
we have this:
{code}
-  private void compact(final byte [] tableNameOrRegionName, final boolean major)
+  private void compact(final byte [] tableNameOrRegionName,
+    final byte[] columnFamily,final boolean major)
{code}

and this:
{code}
   private void compact(final ServerName sn, final HRegionInfo hri,
-      final boolean major)
+      final boolean major, final byte [] family)
{code}

Maybe the order should be consistent...? (Also a space missing the former.)
But since it's in trunk already let's leave it this way in 0.94.

                
> Per-CF compaction Via the Shell
> -------------------------------
>
>                 Key: HBASE-4913
>                 URL: https://issues.apache.org/jira/browse/HBASE-4913
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, regionserver
>            Reporter: Nicolas Spiegelberg
>            Assignee: Mubarak Seyed
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira