Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 30 Nov 2012 20:46:01 +0000 (UTC)
From: "Adrian Muraru (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <6104752.46946.1354308361238.JavaMail.jiratomcat@arcas>
In-Reply-To: <1121380956.132.1349431923662.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-6956) Do not return back to HTablePool
 closed connections
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507639#comment-13507639 ] 

Adrian Muraru commented on HBASE-6956:
--------------------------------------

There is an ongoing discussion on HBASE-6580 addressing this issue, a broader scope but would resolve the broken HConnection discussed here.
The agreement there was to deprecate HTablePool and rely on lightweight (read cheap) HTable (HBASE-4805) retrieved from a new HConnection#getTable()

I have a patch on HBASE-6580 that proposes a new HTableInterfaceFactory :https://issues.apache.org/jira/secure/attachment/12554094/HBASE-6580_v1.patch
and can be used as a custom factory when creating the HTablePool 
{noformat}org.apache.hadoop.hbase.client.HTablePool.HTablePool(Configuration config, int maxSize, HTableInterfaceFactory tableFactory){noformat}
                
> Do not return back to HTablePool closed connections
> ---------------------------------------------------
>
>                 Key: HBASE-6956
>                 URL: https://issues.apache.org/jira/browse/HBASE-6956
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.90.6
>            Reporter: Igor Yurinok
>
> Sometimes we see a lot of Exception about closed connections:
> {code}
>  org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation@553fd068 closed
> org.apache.hadoop.hbase.client.ClosedConnectionException: org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation@553fd068 closed
> {code}
> After investigation we assumed that it occurs because closed connection returns back into HTablePool. 
> For our opinion best solution is  check whether the table is closed in method HTablePool.putTable and if true don't add it into the queue and release such HTableInterface.
> But unfortunatly right now there are no access to HTable#closed field through HTableInterface

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira