Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 29 Nov 2012 19:48:59 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <379586605.41638.1354218539762.JavaMail.jiratomcat@arcas>
In-Reply-To: <554180255.21853.1353897298625.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-7215) Put, Delete, Increment, and Result
 still implement Writable
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-7215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506720#comment-13506720 ] 

Lars Hofhansl commented on HBASE-7215:
--------------------------------------

That looks pretty good!
Should probably still upload to RB for easier review.

Two sticky points I know about:
# Result deserialization used to do 8k chunked reading from the input stream to avoid OOM'ing on the JVMs direct memory. I have no idea how protobufs reads from the stream when deserializing so we may get that problem back.
# The size metric in ScannerCallable was broken when protobufs were introduced, because that just measured the size of the bytes stream (that is no longer filled with protobufs). This patch just comments that part, because it was broken anyway.

                
> Put, Delete, Increment, and Result still implement Writable
> -----------------------------------------------------------
>
>                 Key: HBASE-7215
>                 URL: https://issues.apache.org/jira/browse/HBASE-7215
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7215-v2.txt, 7215v3_mutableresult.txt, 7215v3.txt, 7215v4.txt, 7215v5.txt, 7215v6.txt, 7215v7.txt, 7215v7.txt, 7251-SKETCH.txt, MutableResult.java
>
>
> Making blocker as suggested by Stack.
> At least the following still use Put/Delete as writables.
> * IdentityTableReduce.java
> * MultiPut.java
> * HRegionServer.checkAndMutate

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira