Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 6 Nov 2012 19:38:13 +0000 (UTC)
From: "Gustavo Anatoly (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1605862609.76027.1352230693398.JavaMail.jiratomcat@arcas>
In-Reply-To: <102536546.23312.1341844714677.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491754#comment-13491754 ] 

Gustavo Anatoly commented on HBASE-6356:
----------------------------------------

Hi, Nicolas.

About the message LOG.warn I think is good, because the log reader will understand what happened, and continue with a not valid return, but about your second question, would you like that check if Path#toString() is really a name before passed to the LOG.warn?

Thanks for your patience.
                
> printStackTrace in FSUtils
> --------------------------
>
>                 Key: HBASE-6356
>                 URL: https://issues.apache.org/jira/browse/HBASE-6356
>             Project: HBase
>          Issue Type: Bug
>          Components: Client, master, regionserver
>    Affects Versions: 0.96.0
>            Reporter: nkeywal
>            Priority: Trivial
>              Labels: noob
>
> This is bad...
> {noformat}
>     public boolean accept(Path p) {
>       boolean isValid = false;
>       try {
>         if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
>           isValid = false;
>         } else {
>             isValid = this.fs.getFileStatus(p).isDir();
>         }
>       } catch (IOException e) {
>         e.printStackTrace();          <================ 
>       }
>       return isValid;
>     }
>   }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira